ea7e4b2ab5
Fix previous commits not actually nulling out the key
...
I goofed while porting this from H'uru, where the variable is a
reference. The previous code actually caused the keys to not get deleted
at all.
2023-06-26 00:16:24 +02:00
5d5ba00f7d
Also guard against accessing plRegistryKeyList currently being deleted
...
Co-authored-by: Adam Johnson <AdamJohnso@gmail.com >
(ported from H-uru/Plasma@725eeaa288 )
2023-06-25 16:50:10 +02:00
af38137822
Fix possible use after free in plRegistryPageNode::UnloadKeys
...
Short explanation: the destructor of plRegistryKeyList may indirectly
access other entries of fKeyLists where the plRegistryKeyList has
already been deleted, but not yet removed from the map.
Long explanation:
* Deleting a plRegistryKeyList also deletes all plKeys inside it, which
decrements the reference count of the objects they point to.
* If one of the deleted keys happens to be the last reference to an
object, this also deletes the object itself.
* The object's destructor might in turn delete another plKey, which
calls SetKeyUnused, which tries to look up the key in its page.
* If this second plKey belongs to the page that is currently being
unloaded, then its plRegistryKeyList may be partially or completely
deleted, but still listed in the fKeyLists map. In this case, the key
lookup accesses already freed memory.
(ported from H-uru/Plasma@a529e35fd9 )
2023-06-25 16:44:35 +02:00
4b0ab75a79
Merge branch 'ticket/49'
2022-11-12 10:30:24 -07:00
dcb0309a08
closes #49
2022-11-12 10:29:57 -07:00
7dde0855dc
Merge branch 'ticket/48'
2022-11-12 10:13:57 -07:00
44c9b0694d
Merge branch 'ticket/47'
2022-11-12 10:13:53 -07:00
dedf04ac43
Merge branch 'ticket/45'
2022-11-12 10:13:50 -07:00
eeb458817f
Merge branch 'ticket/44'
2022-11-12 10:13:43 -07:00
68c7187155
closes #48
2022-11-12 10:13:17 -07:00
6fa695a2c3
closes #47
2022-11-12 10:12:53 -07:00
2a3c1b32ef
closes #45
2022-11-12 10:11:59 -07:00
d3cbaa94ef
closes #44
2022-11-12 10:11:24 -07:00
e7758ccc10
Merge branch 'ticket/49'
2022-10-23 10:46:15 -06:00
07b92234ad
Fix bug for python SDL variable-length arrays
2022-10-03 21:48:57 -05:00
7dfa2ba56a
Merge branch 'master' into working
2022-07-19 08:55:00 -06:00
1a091b7019
Merge branch 'ticket/48'
2022-06-05 15:14:09 -06:00
104a5ef4ee
Merge branch 'ticket/47'
2022-06-05 15:13:55 -06:00
19cfaaaea9
Merge branch 'ticket/45'
2022-06-05 15:13:41 -06:00
dafd190083
Merge branch 'ticket/44'
2022-06-05 15:13:26 -06:00
fdee5a921b
Merge branch 'ticket/47' of https://foundry.openuru.org/gitblit/r/CWE-ou-minkata into ticket/47
2022-05-30 14:23:43 -07:00
b322ee094c
Fix compile error
2022-05-30 14:23:20 -07:00
54c768d966
PR from Huru to prevent dynamics from moving during age initilization
2022-05-30 14:22:12 -07:00
82159bcb4a
Merge branch 'ticket/47' of https://foundry.openuru.org/gitblit/r/CWE-ou-minkata into ticket/47
2022-05-30 14:04:22 -07:00
b81eb21145
Fix compile error
...
Author: Adam Johnson <AdamJohnso@gmail.com >
2022-05-30 14:03:33 -07:00
e7b4f5c6ba
Fix compile error
...
(cherry picked from commit 202e846a56
2022-05-11 15:20:16 -06:00
202e846a56
Fix compile error
2022-05-11 14:16:44 -07:00
deb4858f3e
Add subtitle and loc key message flags
...
(cherry picked from commit 126e7a76dd
2022-05-11 13:58:51 -06:00
bff879abfd
PR from Huru to prevent dynamics from moving during age initilization
2022-05-11 13:58:51 -06:00
fededb574b
Change to prevent crashing when fCurStage is null
2022-05-11 13:58:51 -06:00
126e7a76dd
Add subtitle and loc key message flags
2022-05-10 20:07:41 -05:00
26807a8d87
Merge branch 'ticket/47'
2022-05-05 09:45:42 -06:00
f54f14328e
PR from Huru to prevent dynamics from moving during age initilization
2022-05-04 20:16:58 -07:00
311671e7a2
Merge branch 'ticket/46'
...
closes #46
2022-04-29 14:55:59 -06:00
8aaa98b8b7
Change to prevent crashing when fCurStage is null
2022-04-29 07:46:54 -07:00
3489e04463
Fix crash from plMouseDevice::HideCursor if it is called before cursor is created
2022-04-06 19:46:00 -05:00
33bbc490be
Minor code quality correction
2022-04-06 19:32:30 -05:00
fd0c2a205e
Fix nondeterministic conflicting page processing on startup
2022-04-06 19:18:05 -05:00
b2521e0777
Merge branch 'ticket/42'
...
closes #42
2022-03-23 09:22:29 -06:00
1f7de46bc2
Expand thread memory allocations for stack and heap to 1.25MB
2022-03-22 13:53:50 -06:00
f9d629cfc5
Expand thread memory allocations for stack and heap to 1.25MB
2022-03-22 13:52:03 -06:00
b16de9d86f
Merge branch 'master' into working
2022-03-19 21:41:37 -06:00
aba5e2562c
Merge branch 'ticket/38'
...
closes #38
2022-03-19 21:39:41 -06:00
bff8203fbe
Merge branch 'ticket/38' of https://foundry.openuru.org/gitblit/r/CWE-ou-minkata into ticket/38
2022-03-19 22:15:28 -05:00
23ded3210f
By popular demand, enable subtitles by default
2022-03-19 22:15:14 -05:00
bbeb25d29a
Merge branch 'master' into working
2022-03-12 09:16:15 -07:00
9f9d510958
Merge branch 'ticket/38'
...
closes #38
2022-03-12 09:15:42 -07:00
f0d2bd3eaa
Don't feed remaining subtitles when audio skips to past the end of last subtitle
...
(cherry picked from commit 40bcaba9d8
2022-03-11 10:05:46 -07:00
41627d1c7c
Merge branch 'master' into working
2022-03-11 10:03:31 -07:00
ea4bb43623
Merge branch 'ticket/38' of https://foundry.openuru.org/gitblit/r/CWE-ou-minkata into ticket/38
2022-03-11 10:59:08 -06:00
