dgelessus
7d3774a732
Unload all keys of all pages before deleting them
...
(ported from H-uru/Plasma@04d0ac94ea25fc937931b8f4f546220ddf1cc27c)
1 year ago
dgelessus
ea7e4b2ab5
Fix previous commits not actually nulling out the key
...
I goofed while porting this from H'uru, where the variable is a
reference. The previous code actually caused the keys to not get deleted
at all.
1 year ago
dgelessus
5d5ba00f7d
Also guard against accessing plRegistryKeyList currently being deleted
...
Co-authored-by: Adam Johnson <AdamJohnso@gmail.com>
(ported from H-uru/Plasma@725eeaa28820423f8f36e3476d0f5c6da30921c2)
1 year ago
dgelessus
af38137822
Fix possible use after free in plRegistryPageNode::UnloadKeys
...
Short explanation: the destructor of plRegistryKeyList may indirectly
access other entries of fKeyLists where the plRegistryKeyList has
already been deleted, but not yet removed from the map.
Long explanation:
* Deleting a plRegistryKeyList also deletes all plKeys inside it, which
decrements the reference count of the objects they point to.
* If one of the deleted keys happens to be the last reference to an
object, this also deletes the object itself.
* The object's destructor might in turn delete another plKey, which
calls SetKeyUnused, which tries to look up the key in its page.
* If this second plKey belongs to the page that is currently being
unloaded, then its plRegistryKeyList may be partially or completely
deleted, but still listed in the fKeyLists map. In this case, the key
lookup accesses already freed memory.
(ported from H-uru/Plasma@a529e35fd940543752fd74efd0fe63039a03c4a6)
1 year ago
rarified
4b0ab75a79
Merge branch 'ticket/49'
2 years ago
rarified
dcb0309a08
closes #49
2 years ago
rarified
7dde0855dc
Merge branch 'ticket/48'
2 years ago
rarified
44c9b0694d
Merge branch 'ticket/47'
2 years ago
rarified
dedf04ac43
Merge branch 'ticket/45'
2 years ago
rarified
eeb458817f
Merge branch 'ticket/44'
2 years ago
rarified
68c7187155
closes #48
2 years ago
rarified
6fa695a2c3
closes #47
2 years ago
rarified
2a3c1b32ef
closes #45
2 years ago
rarified
d3cbaa94ef
closes #44
2 years ago
rarified
e7758ccc10
Merge branch 'ticket/49'
2 years ago
Adam Johnson
07b92234ad
Fix bug for python SDL variable-length arrays
2 years ago
rarified
7dfa2ba56a
Merge branch 'master' into working
2 years ago
rarified
1a091b7019
Merge branch 'ticket/48'
2 years ago
rarified
104a5ef4ee
Merge branch 'ticket/47'
2 years ago
rarified
19cfaaaea9
Merge branch 'ticket/45'
2 years ago
rarified
dafd190083
Merge branch 'ticket/44'
2 years ago
Edmond Mondor
fdee5a921b
Merge branch 'ticket/47' of https://foundry.openuru.org/gitblit/r/CWE-ou-minkata into ticket/47
2 years ago
Adam Johnson
b322ee094c
Fix compile error
2 years ago
Adam Johnson
54c768d966
PR from Huru to prevent dynamics from moving during age initilization
2 years ago
Edmond Mondor
82159bcb4a
Merge branch 'ticket/47' of https://foundry.openuru.org/gitblit/r/CWE-ou-minkata into ticket/47
2 years ago
Edmond Mondor
b81eb21145
Fix compile error
...
Author: Adam Johnson <AdamJohnso@gmail.com>
2 years ago
Edmond Mondor
e7b4f5c6ba
Fix compile error
...
(cherry picked from commit 202e846a56
)
3 years ago
Edmond Mondor
202e846a56
Fix compile error
3 years ago
ZarothYe
deb4858f3e
Add subtitle and loc key message flags
...
(cherry picked from commit 126e7a76dd
)
3 years ago
Edmond Mondor
bff879abfd
PR from Huru to prevent dynamics from moving during age initilization
3 years ago
Edmond Mondor
fededb574b
Change to prevent crashing when fCurStage is null
3 years ago
ZarothYe
126e7a76dd
Add subtitle and loc key message flags
3 years ago
rarified
26807a8d87
Merge branch 'ticket/47'
3 years ago
Edmond Mondor
f54f14328e
PR from Huru to prevent dynamics from moving during age initilization
3 years ago
rarified
311671e7a2
Merge branch 'ticket/46'
...
closes #46
3 years ago
Edmond Mondor
8aaa98b8b7
Change to prevent crashing when fCurStage is null
3 years ago
Adam Johnson
3489e04463
Fix crash from plMouseDevice::HideCursor if it is called before cursor is created
3 years ago
Adam Johnson
33bbc490be
Minor code quality correction
3 years ago
Adam Johnson
fd0c2a205e
Fix nondeterministic conflicting page processing on startup
3 years ago
rarified
b2521e0777
Merge branch 'ticket/42'
...
closes #42
3 years ago
rarified
1f7de46bc2
Expand thread memory allocations for stack and heap to 1.25MB
3 years ago
rarified
f9d629cfc5
Expand thread memory allocations for stack and heap to 1.25MB
3 years ago
rarified
b16de9d86f
Merge branch 'master' into working
3 years ago
rarified
aba5e2562c
Merge branch 'ticket/38'
...
closes #38
3 years ago
ZarothYe
bff8203fbe
Merge branch 'ticket/38' of https://foundry.openuru.org/gitblit/r/CWE-ou-minkata into ticket/38
3 years ago
ZarothYe
23ded3210f
By popular demand, enable subtitles by default
3 years ago
rarified
bbeb25d29a
Merge branch 'master' into working
3 years ago
rarified
9f9d510958
Merge branch 'ticket/38'
...
closes #38
3 years ago
ZarothYe
f0d2bd3eaa
Don't feed remaining subtitles when audio skips to past the end of last subtitle
...
(cherry picked from commit 40bcaba9d8
)
3 years ago
rarified
41627d1c7c
Merge branch 'master' into working
3 years ago