After hacking the old to just barely use plString, I received some UTF-8
asserts. So, that seemed like a good excuse to convert the whole mess to
plString. Note that the output is now saved in VaultClient.log. This
should help with getting some of the chaos out of OLD_ASYNC_LOG.log
NetVaultNode now uses plStrings. I also took the liberty of removing code
that was really only useful in server contexts. Note that there is
absolutely no way this will compile at the moment. Future commits will fix
the other code to play nicely with this rewrite.
In this case it now also works for non-owners of the age. Previously it only worked for owners because the ageInfoStruct does not contain the vault node ID, so it needed to be looked up somewhere, and that was in the AgesIOwnFolder.
- Removes Bink headers.
- Remove usage of Bink movie layers in pfJournalBook (replacing it
with plLayerAVI in the interim).
- Removes Bink cmake.
Conflicts:
CMakeLists.txt
Sources/Plasma/Apps/plClient/plClient.cpp
Sources/Plasma/PubUtilLib/plPipeline/plBinkPlayer.h
Also, the text of the faded-out player list is re-rendered with alpha == 0 every time the mouse enters its area, do a little less needless work in that case.
This reverts commit b393947cd5.
The commit was seemingly harmless, but it created or otherwise uncovered
stack corruption deep inside the vault voodoo. While I would like to know
what was up, I'm tired of dealing with it. The crash addressed here was
fixed in a subsequent moul-scripts commit, so let's just toss this one.
This code called back into the python vault operation thingy, which
deletes itself. So, anytime we got dupe CBs, there was a use-after-free
error. Nasty crashes. I tightened up the CB management, threw away some
weird faux-management mess, and squashed some potential silent bugs.