Merged in cwalther/cwe/statusmessagecrash (pull request #31)

Don't crash when the HTTP request for getting the server status message fails

This fixes the crash that keeps Windows 7 users out of the game when support.cyanworlds.com is down, reported with some regularity e.g. at http://mystonline.com/forums/viewtopic.php?f=40&t=27352 .

Apparently on Windows 7, unlike on Windows XP and contrary to its documentation, WinHttpReadData() does not zero its lpdwNumberOfBytesRead argument when called with an invalid request, so the lack of error checking here bites.

MOULOpenSourceClientPlugin/Plasma20/Sources/Plasma/Apps/plClient/winmain.cpp

@@ -1250,6 +1250,7 @@ void StatusCallback(void *param)
 					{
 						static char data[256] = {0};
 						DWORD bytesRead;
+						if(
 							WinHttpSendRequest( 
 								hRequest, 
 								WINHTTP_NO_ADDITIONAL_HEADERS,
@@ -1258,15 +1259,18 @@ void StatusCallback(void *param)
 								0,
 								0,
 								0
-						);
+							)
-						WinHttpReceiveResponse(hRequest, 0);
+							&& WinHttpReceiveResponse(hRequest, 0)
-						WinHttpReadData(hRequest, data, 255, &bytesRead);
+							&& WinHttpReadData(hRequest, data, 255, &bytesRead)
+							&& bytesRead
+						)
+						{
 							data[bytesRead] = 0;
-						if(bytesRead)
 							PostMessage(hwnd, WM_USER_SETSTATUSMSG, 0, (LPARAM) data);
 						}
 					}
 				}
+			}
 			WinHttpCloseHandle(hRequest);
 			WinHttpCloseHandle(hConnect);
 			WinHttpCloseHandle(hSession);