dgelessus
5d5ba00f7d
Also guard against accessing plRegistryKeyList currently being deleted
...
Co-authored-by: Adam Johnson <AdamJohnso@gmail.com>
(ported from H-uru/Plasma@725eeaa28820423f8f36e3476d0f5c6da30921c2)
2 years ago
dgelessus
af38137822
Fix possible use after free in plRegistryPageNode::UnloadKeys
...
Short explanation: the destructor of plRegistryKeyList may indirectly
access other entries of fKeyLists where the plRegistryKeyList has
already been deleted, but not yet removed from the map.
Long explanation:
* Deleting a plRegistryKeyList also deletes all plKeys inside it, which
decrements the reference count of the objects they point to.
* If one of the deleted keys happens to be the last reference to an
object, this also deletes the object itself.
* The object's destructor might in turn delete another plKey, which
calls SetKeyUnused, which tries to look up the key in its page.
* If this second plKey belongs to the page that is currently being
unloaded, then its plRegistryKeyList may be partially or completely
deleted, but still listed in the fKeyLists map. In this case, the key
lookup accesses already freed memory.
(ported from H-uru/Plasma@a529e35fd940543752fd74efd0fe63039a03c4a6)
2 years ago
Adam Johnson
07b92234ad
Fix bug for python SDL variable-length arrays
2 years ago
Adam Johnson
b322ee094c
Fix compile error
3 years ago
Adam Johnson
54c768d966
PR from Huru to prevent dynamics from moving during age initilization
3 years ago
Edmond Mondor
b81eb21145
Fix compile error
...
Author: Adam Johnson <AdamJohnso@gmail.com>
3 years ago
Edmond Mondor
e7b4f5c6ba
Fix compile error
...
(cherry picked from commit 202e846a56
3 years ago
Edmond Mondor
202e846a56
Fix compile error
3 years ago
deb4858f3e
Add subtitle and loc key message flags
...
(cherry picked from commit 126e7a76dd
3 years ago
Edmond Mondor
bff879abfd
PR from Huru to prevent dynamics from moving during age initilization
3 years ago
Edmond Mondor
fededb574b
Change to prevent crashing when fCurStage is null
3 years ago
126e7a76dd
Add subtitle and loc key message flags
3 years ago
Edmond Mondor
f54f14328e
PR from Huru to prevent dynamics from moving during age initilization
3 years ago
Edmond Mondor
8aaa98b8b7
Change to prevent crashing when fCurStage is null
3 years ago
Adam Johnson
3489e04463
Fix crash from plMouseDevice::HideCursor if it is called before cursor is created
3 years ago
Adam Johnson
33bbc490be
Minor code quality correction
3 years ago
Adam Johnson
fd0c2a205e
Fix nondeterministic conflicting page processing on startup
3 years ago
23ded3210f
By popular demand, enable subtitles by default
3 years ago
f0d2bd3eaa
Don't feed remaining subtitles when audio skips to past the end of last subtitle
...
(cherry picked from commit 40bcaba9d8
3 years ago
40bcaba9d8
Don't feed remaining subtitles when audio skips to past the end of last subtitle
3 years ago
e93db035ba
Revert "Fixes bug where avatar run-lock state can get confused after alt-tabbing"
...
This reverts commit 69dac251b6
3 years ago
c0e83259f3
Don't display previous subtitles all at once when subtitles are enabled mid-audio play
...
(cherry picked from commit 40f200e066
3 years ago
40f200e066
Don't display previous subtitles all at once when subtitles are enabled mid-audio play
3 years ago
6e4996e1be
Ensure pyGUIControlListBox::GetElementW can't attempt to return a null pointer as a std::wstring
...
(cherry picked from commit 2f1bb87056
3 years ago
2f1bb87056
Ensure pyGUIControlListBox::GetElementW can't attempt to return a null pointer as a std::wstring
3 years ago
Adam Johnson
df848b48c4
Prevent deferred link race conditions
...
(cherry picked from commit e512dd0c68
3 years ago
Adam Johnson
e512dd0c68
Prevent deferred link race conditions
3 years ago
9e308cbebe
Fix another log string formatting issue found by Adam.
3 years ago
126d7511e0
Fix parentheses mistake for retrieving streaming audio timings and apply code fix suggestions from Adam
3 years ago
64323c6073
Apply code suggestions from rarified
3 years ago
3b17e20fb9
Revert "Initial port of Mystler's code"
...
This reverts commit b0511ea068
3 years ago
Adam Johnson
8a2534dff6
Simplify SRT file path construction with suggestion from Hoikas
3 years ago
25ea208084
Revert "Add read and write file functions for clothing"
...
This reverts commit afed53f920
3 years ago
a392a37fcd
Revert "Change to ReadFromFile command per rarified"
...
This reverts commit f90ab01d44
3 years ago
7c64654e1f
Revert "More odds and ends from Mystler's PRs"
...
This reverts commit a82188cbf4
3 years ago
9a1b37e7f6
Turn std::strings into char* before doing PyObject_CallMethod with them
3 years ago
1012251d9a
Add missing message dispatch registration
3 years ago
1d65c78097
Fix bad include, missing static declaration, SRT path directory, and formatting
3 years ago
c50bb08e8d
Fix usage and overflow bug causing plWin32StreamingSound::GetActualTimeSec() to return absurd values. Needed fix for subtitle timings.
3 years ago
229883654e
Initial pass at getting subtitle support in. Doesn't compile for unknown reasons
3 years ago
a82188cbf4
More odds and ends from Mystler's PRs
...
(cherry picked from commit eb40f86349
3 years ago
f90ab01d44
Change to ReadFromFile command per rarified
...
(cherry picked from commit 9e83bf7c8d
3 years ago
afed53f920
Add read and write file functions for clothing
...
(cherry picked from commit 4f13d37905
3 years ago
b0511ea068
Initial port of Mystler's code
...
Add coding from Mystler's original commits
(cherry picked from commit 6b3b966f81
3 years ago
Adam Johnson
dfc89b363c
Don't update to visible arrow when cursor should be hidden
...
(cherry picked from commit 51b6b4750b
3 years ago
Adam Johnson
9ab07771df
Fixes bug where avatar run-lock state can get confused after alt-tabbing
...
(cherry picked from commit 69dac251b6
3 years ago
Adam Johnson
51b6b4750b
Don't update to visible arrow when cursor should be hidden
3 years ago
Adam Johnson
69dac251b6
Fixes bug where avatar run-lock state can get confused after alt-tabbing
3 years ago
Edmond Mondor
fd260827aa
Fix error due to no Empty()
...
(cherry picked from commit e81af06584
3 years ago
Edmond Mondor
e81af06584
Fix error due to no Empty()
3 years ago
dgelessus
Adam Johnson
Edmond Mondor
ZarothYe
rarified
Mystler