From 1835e6b5c616d494ada8c95a365a977a0d3ad5fa Mon Sep 17 00:00:00 2001 From: Adam Johnson Date: Fri, 7 Aug 2015 13:16:28 -0400 Subject: [PATCH] Fix weird camera angles caused by 9c49b57 The reason for the previous commit was that coverity indicated view was being passed to up and vice versa. I don't know what they were intending, but the calculation was correct, just the argument naming was wrong. This has all been corrected now. --- Sources/Plasma/FeatureLib/pfCamera/plCameraBrain.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Sources/Plasma/FeatureLib/pfCamera/plCameraBrain.cpp b/Sources/Plasma/FeatureLib/pfCamera/plCameraBrain.cpp index f7f691cc..47256715 100644 --- a/Sources/Plasma/FeatureLib/pfCamera/plCameraBrain.cpp +++ b/Sources/Plasma/FeatureLib/pfCamera/plCameraBrain.cpp @@ -1565,14 +1565,13 @@ void plCameraBrain1_Fixed::Update(bool forced) if (fCamera->GetTarget()) { fTargetMatrix = fCamera->GetTarget()->GetCoordinateInterface()->GetLocalToWorld(); - hsVector3 view; hsVector3 up; - fTargetMatrix.GetAxis(0, &up, &view); + fTargetMatrix.GetAxis(nullptr, &up, nullptr); fGoal = fTargetMatrix.GetTranslate(); if (fTargetPoint) fPOAGoal = fTargetPoint->GetBrain()->GetGoal(); else - fPOAGoal = fGoal - (view * 10); + fPOAGoal = fGoal - (up * 10); } } if (fFlags.IsBitSet(kRailComponent) && fRail)