OU/CWE-ou-minkata
1
0
Fork 0
mirror of https://foundry.openuru.org/gitblit/r/CWE-ou-minkata.git synced 2025-07-21 20:59:09 +00:00
Code Releases Activity

Fix read of unitialized variable if a GUI element is not found.

Browse Source
This commit is contained in:
philippelatulippe
2011-05-15 21:49:51 -04:00
parent f211d76bfb
commit ccbedc6306
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Sources/Plasma/FeatureLib/pfGameGUIMgr/pfGUIListBoxMod.cpp
View File

@ -766,7 +766,7 @@ Int32 pfGUIListBoxMod::IGetItemFromPoint( hsPoint3 &mousePt )
hsPoint3 localPt = mousePt; // despite getting a ref to the point (why?) we do NOT want to modify it hsPoint3 localPt = mousePt; // despite getting a ref to the point (why?) we do NOT want to modify it
IScreenToLocalPt( localPt ); IScreenToLocalPt( localPt );
UInt32 i; UInt32 i;
Int16 clickItem, clickY = (Int16)( localPt.fY * ( fDynTextMap->GetVisibleHeight() - 1 ) ); Int16 clickItem = -1 , clickY = (Int16)( localPt.fY * ( fDynTextMap->GetVisibleHeight() - 1 ) );
Int16 clickX = (Int16)( localPt.fX * ( fDynTextMap->GetVisibleWidth() - 1 ) ); Int16 clickX = (Int16)( localPt.fX * ( fDynTextMap->GetVisibleWidth() - 1 ) );
// We have a nice array that has the starting (top) Y's of each visible element. So we just // We have a nice array that has the starting (top) Y's of each visible element. So we just
@ -791,7 +791,7 @@ Int32 pfGUIListBoxMod::IGetItemFromPoint( hsPoint3 &mousePt )
} }
} }
if( clickItem > fElements.GetCount() - 1 || clickItem < 0 ) if( clickItem > fElements.GetCount() - 1 )
clickItem = -1; clickItem = -1;
return clickItem; return clickItem;