From c015d86e10d2cfe10869ea5daf804cce1b4810f7 Mon Sep 17 00:00:00 2001 From: rarified Date: Thu, 22 Jul 2021 13:51:48 -0600 Subject: [PATCH] #7 --- id/07/7/journal.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/id/07/7/journal.json b/id/07/7/journal.json index fe611fdd..df627bee 100644 --- a/id/07/7/journal.json +++ b/id/07/7/journal.json @@ -1 +1 @@ -[{"date":"2021-05-31T18:03:16Z","author":"marten","fields":{"title":"Hoikas\u0027 subworld fixes including PhysX support 1) Allow plSubWorldMsg to be sent over the network https://github.com/H-uru/Plasma/pull/107 2) Cleanup VolumeSensorConditionalObject https://github.com/H-uru/Plasma/pull/537 3) Add two new compiler feature tests - HeadSpin.h changes ONLY, as prerequisite for VolumeSensorConditionalObject https://github.com/H-uru/Plasma/commit/45be91c0e37cbd8131afe0b1dec468ba61e5e52c 4) Fix a crash and a silly identified by Coverity - changes for VolumeSensorConditionalObject ONLY https://github.com/H-uru/Plasma/pull/851/commits/a702cb9d3fb1dd453d4bbf94ffb92b3586f1fe82 5) PXSubworld (Havok/CC subworld physics support ported to PhysX/MOULa) https://github.com/H-uru/Plasma/pull/555","body":"","status":"New","mergeTo":"master","type":"Proposal","watchers":"+marten"},"patchset":{"number":1,"rev":1,"tip":"576ac25f03a5dd4980dd9deaea270bfe63ef0381","base":"c914ba5bac1da37892ef196abe36a1177842e6ee","insertions":545,"deletions":421,"commits":1,"added":0,"type":"Proposal"}},{"date":"2021-05-31T18:15:19Z","author":"marten","patchset":{"number":1,"rev":2,"tip":"59b45769eeb14cc608315c71d8f6094d2a4863a6","parent":"576ac25f03a5dd4980dd9deaea270bfe63ef0381","base":"c914ba5bac1da37892ef196abe36a1177842e6ee","insertions":1,"deletions":2,"commits":2,"added":1,"type":"FastForward"}},{"date":"2021-06-05T06:08:24Z","author":"hoikas","comment":{"text":"FWIW, if something is marked `override` or `final`, then it doesn\u0027t need to (and probably should not be) marked `virtual`.","id":"ced2122785dc616ba4186e2b107e18e181b7b849"},"fields":{"watchers":"+hoikas"}},{"date":"2021-06-06T01:41:22Z","author":"rarified","comment":{"text":"In plLogicModBase.cpp#176 method IHandleArbitration() the call to DebugMsg() appears to use a string_theory formatting string, rather than the older printf() style format. None of the values being logged will appear in the output. I need to check DebugMsg() to be 100% sure, but I’m pretty confident that is the case.","id":"001b06fdfd3dbd147d5e278c264255d4adf27415"},"fields":{"watchers":"+rarified"}},{"date":"2021-06-06T03:13:47Z","author":"marten","patchset":{"number":1,"rev":3,"tip":"0c5c58679143b13b33a9348093e0759ea7812196","parent":"59b45769eeb14cc608315c71d8f6094d2a4863a6","base":"c914ba5bac1da37892ef196abe36a1177842e6ee","insertions":3,"deletions":2,"commits":3,"added":1,"type":"FastForward"}},{"date":"2021-06-06T03:14:05Z","author":"marten","comment":{"text":"@rarified You are correct, I\u0027ve pushed a fix.","id":"34479128a1599fe9fccbd6447f01894c9863899b"},"fields":{"mentions":"+rarified"}},{"date":"2021-06-06T03:24:19Z","author":"marten","patchset":{"number":1,"rev":4,"tip":"40c692d6a9ec5441e2949edf32c6dc18378daed1","parent":"0c5c58679143b13b33a9348093e0759ea7812196","base":"c914ba5bac1da37892ef196abe36a1177842e6ee","insertions":1,"deletions":1,"commits":4,"added":1,"type":"FastForward"}},{"date":"2021-06-06T03:24:37Z","author":"marten","comment":{"text":"@Adam Johnson Fix pushed. Thanks!","id":"6c285b99347a542aa006afca3ca0b7bf9c50e0c9"},"fields":{"mentions":"+Adam"}},{"date":"2021-06-06T18:50:51Z","author":"marten","patchset":{"number":1,"rev":5,"tip":"a6c941b08713be1621590e16b342fce0015999f4","parent":"40c692d6a9ec5441e2949edf32c6dc18378daed1","base":"c914ba5bac1da37892ef196abe36a1177842e6ee","insertions":1,"deletions":1,"commits":5,"added":1,"type":"FastForward"}},{"date":"2021-06-06T19:17:48Z","author":"rarified","fields":{"watchers":"-rarified"}},{"date":"2021-06-06T19:17:49Z","author":"rarified","fields":{"watchers":"+rarified"}},{"date":"2021-06-06T21:53:26Z","author":"marten","patchset":{"number":1,"rev":6,"tip":"22d7ff292c70b139d16cfc99163e58f8a98c5722","parent":"a6c941b08713be1621590e16b342fce0015999f4","base":"c914ba5bac1da37892ef196abe36a1177842e6ee","insertions":9,"deletions":9,"commits":6,"added":1,"type":"FastForward"}},{"date":"2021-06-06T22:28:52Z","author":"marten","comment":{"text":"Tested this today. Found one mistake I had made and fixed it.\n\nOn a Debug Internal build, against Minkata Prime, first time I linked to Teledahn I received some sort of invalid message error and was booted out. I traced back to where ReportError() was called in plPythonFileMod MsgReceive.\n\nTried Teledahn several more times and could not repeat the issue.\nRode the \"Up\" elevator in Gahreesen, and rode the bucket in Teledahn, with no issue.","id":"8a2051f9531481cf46e76ae61cf35b97265e58df"}},{"date":"2021-06-27T16:33:09Z","author":"rarified","reference":{"hash":"2ac64918c61ae12af269a58ee032a57150fc1e13"}},{"date":"2021-07-06T16:04:59Z","author":"rarified","comment":{"text":"It appears this change was tolerated well on Minkata, resolving some (but not all) subworld issues.\n\nThe remaining SW issues appear to be embedded in the content PRP data and require work there.","id":"dba7c587d8a56d98838c009009b5c44f10bd7e6a"}},{"date":"2021-07-06T16:05:21Z","author":"rarified","fields":{"reviewers":"+rarified"},"review":{"patchset":1,"rev":6,"score":2}},{"date":"2021-07-06T16:05:32Z","author":"rarified","fields":{"status":"Open"}},{"date":"2021-07-06T16:39:53Z","author":"rarified","fields":{"status":"Merged","mergeSha":"a5b059f89ecabf09579b0f53e2a31468211b9d2c","mergeTo":"master","responsible":"rarified"},"patchset":{"number":2,"rev":1,"tip":"a5b059f89ecabf09579b0f53e2a31468211b9d2c","base":"dfe142361351d4268fd697eee32641155503c338","insertions":545,"deletions":421,"commits":7,"added":1,"type":"Rebase"}}] \ No newline at end of file +[{"date":"2021-05-31T18:03:16Z","author":"marten","fields":{"title":"Hoikas\u0027 subworld fixes including PhysX support 1) Allow plSubWorldMsg to be sent over the network https://github.com/H-uru/Plasma/pull/107 2) Cleanup VolumeSensorConditionalObject https://github.com/H-uru/Plasma/pull/537 3) Add two new compiler feature tests - HeadSpin.h changes ONLY, as prerequisite for VolumeSensorConditionalObject https://github.com/H-uru/Plasma/commit/45be91c0e37cbd8131afe0b1dec468ba61e5e52c 4) Fix a crash and a silly identified by Coverity - changes for VolumeSensorConditionalObject ONLY https://github.com/H-uru/Plasma/pull/851/commits/a702cb9d3fb1dd453d4bbf94ffb92b3586f1fe82 5) PXSubworld (Havok/CC subworld physics support ported to PhysX/MOULa) https://github.com/H-uru/Plasma/pull/555","body":"","status":"New","mergeTo":"master","type":"Proposal","watchers":"+marten"},"patchset":{"number":1,"rev":1,"tip":"576ac25f03a5dd4980dd9deaea270bfe63ef0381","base":"c914ba5bac1da37892ef196abe36a1177842e6ee","insertions":545,"deletions":421,"commits":1,"added":0,"type":"Proposal"}},{"date":"2021-05-31T18:15:19Z","author":"marten","patchset":{"number":1,"rev":2,"tip":"59b45769eeb14cc608315c71d8f6094d2a4863a6","parent":"576ac25f03a5dd4980dd9deaea270bfe63ef0381","base":"c914ba5bac1da37892ef196abe36a1177842e6ee","insertions":1,"deletions":2,"commits":2,"added":1,"type":"FastForward"}},{"date":"2021-06-05T06:08:24Z","author":"hoikas","comment":{"text":"FWIW, if something is marked `override` or `final`, then it doesn\u0027t need to (and probably should not be) marked `virtual`.","id":"ced2122785dc616ba4186e2b107e18e181b7b849"},"fields":{"watchers":"+hoikas"}},{"date":"2021-06-06T01:41:22Z","author":"rarified","comment":{"text":"In plLogicModBase.cpp#176 method IHandleArbitration() the call to DebugMsg() appears to use a string_theory formatting string, rather than the older printf() style format. None of the values being logged will appear in the output. I need to check DebugMsg() to be 100% sure, but I’m pretty confident that is the case.","id":"001b06fdfd3dbd147d5e278c264255d4adf27415"},"fields":{"watchers":"+rarified"}},{"date":"2021-06-06T03:13:47Z","author":"marten","patchset":{"number":1,"rev":3,"tip":"0c5c58679143b13b33a9348093e0759ea7812196","parent":"59b45769eeb14cc608315c71d8f6094d2a4863a6","base":"c914ba5bac1da37892ef196abe36a1177842e6ee","insertions":3,"deletions":2,"commits":3,"added":1,"type":"FastForward"}},{"date":"2021-06-06T03:14:05Z","author":"marten","comment":{"text":"@rarified You are correct, I\u0027ve pushed a fix.","id":"34479128a1599fe9fccbd6447f01894c9863899b"},"fields":{"mentions":"+rarified"}},{"date":"2021-06-06T03:24:19Z","author":"marten","patchset":{"number":1,"rev":4,"tip":"40c692d6a9ec5441e2949edf32c6dc18378daed1","parent":"0c5c58679143b13b33a9348093e0759ea7812196","base":"c914ba5bac1da37892ef196abe36a1177842e6ee","insertions":1,"deletions":1,"commits":4,"added":1,"type":"FastForward"}},{"date":"2021-06-06T03:24:37Z","author":"marten","comment":{"text":"@Adam Johnson Fix pushed. Thanks!","id":"6c285b99347a542aa006afca3ca0b7bf9c50e0c9"},"fields":{"mentions":"+Adam"}},{"date":"2021-06-06T18:50:51Z","author":"marten","patchset":{"number":1,"rev":5,"tip":"a6c941b08713be1621590e16b342fce0015999f4","parent":"40c692d6a9ec5441e2949edf32c6dc18378daed1","base":"c914ba5bac1da37892ef196abe36a1177842e6ee","insertions":1,"deletions":1,"commits":5,"added":1,"type":"FastForward"}},{"date":"2021-06-06T19:17:48Z","author":"rarified","fields":{"watchers":"-rarified"}},{"date":"2021-06-06T19:17:49Z","author":"rarified","fields":{"watchers":"+rarified"}},{"date":"2021-06-06T21:53:26Z","author":"marten","patchset":{"number":1,"rev":6,"tip":"22d7ff292c70b139d16cfc99163e58f8a98c5722","parent":"a6c941b08713be1621590e16b342fce0015999f4","base":"c914ba5bac1da37892ef196abe36a1177842e6ee","insertions":9,"deletions":9,"commits":6,"added":1,"type":"FastForward"}},{"date":"2021-06-06T22:28:52Z","author":"marten","comment":{"text":"Tested this today. Found one mistake I had made and fixed it.\n\nOn a Debug Internal build, against Minkata Prime, first time I linked to Teledahn I received some sort of invalid message error and was booted out. I traced back to where ReportError() was called in plPythonFileMod MsgReceive.\n\nTried Teledahn several more times and could not repeat the issue.\nRode the \"Up\" elevator in Gahreesen, and rode the bucket in Teledahn, with no issue.","id":"8a2051f9531481cf46e76ae61cf35b97265e58df"}},{"date":"2021-06-27T16:33:09Z","author":"rarified","reference":{"hash":"2ac64918c61ae12af269a58ee032a57150fc1e13"}},{"date":"2021-07-06T16:04:59Z","author":"rarified","comment":{"text":"It appears this change was tolerated well on Minkata, resolving some (but not all) subworld issues.\n\nThe remaining SW issues appear to be embedded in the content PRP data and require work there.","id":"dba7c587d8a56d98838c009009b5c44f10bd7e6a"}},{"date":"2021-07-06T16:05:21Z","author":"rarified","fields":{"reviewers":"+rarified"},"review":{"patchset":1,"rev":6,"score":2}},{"date":"2021-07-06T16:05:32Z","author":"rarified","fields":{"status":"Open"}},{"date":"2021-07-06T16:39:53Z","author":"rarified","fields":{"status":"Merged","mergeSha":"a5b059f89ecabf09579b0f53e2a31468211b9d2c","mergeTo":"master","responsible":"rarified"},"patchset":{"number":2,"rev":1,"tip":"a5b059f89ecabf09579b0f53e2a31468211b9d2c","base":"dfe142361351d4268fd697eee32641155503c338","insertions":545,"deletions":421,"commits":7,"added":1,"type":"Rebase"}},{"date":"2021-07-22T19:51:48Z","author":"rarified","reference":{"hash":"2ac64918c61ae12af269a58ee032a57150fc1e13"}}] \ No newline at end of file