#8

id/08/8/journal.json

@@ -1 +1 @@
-[{"date":"2021-05-31T22:03:37Z","author":"marten","fields":{"title":"Hoikas\u0027 framerate unlock https://github.com/H-uru/Plasma/pull/143","body":"","status":"New","mergeTo":"master","type":"Proposal","watchers":"+marten"},"patchset":{"number":1,"rev":1,"tip":"e455a71c2ed3eb6215c2ab5e59e712dd2a49a56b","base":"c914ba5bac1da37892ef196abe36a1177842e6ee","insertions":32,"deletions":70,"commits":1,"added":0,"type":"Proposal"}},{"date":"2021-06-05T06:13:01Z","author":"hoikas","comment":{"text":"When this is being tested, we should watch out for the fissure camera cinematic being played on link-in to Relto. This is an intermittent issue that was fairly common common in Until Uru that I remember cropping back up during the framerate unlocking.","id":"6f38f4cde0ca8941876c452270f71496728e1a40"},"fields":{"watchers":"+hoikas"}},{"date":"2021-06-14T21:05:34Z","author":"marten","comment":{"text":"Just a quick note that this commit is not ready for prime time.  It builds, but it crashes.\n\nSome notes:\n* In H\u0027uru Plasma, the unlock frame rate patch was introduced Feb 8, 2012.  \n* The unlock frame rate change is relatively straightforward, but includes a PhysX change.\n* The crash doesn\u0027t appear to be happening in any of the changed code.\n* There are prior PhysX changes in H\u0027uru Plasma from Jan 20 2012 to Feb 6 2012 not yet ported to CWE-ou.\n* Furthermore, PhysX changes from Skoader were introduced in CWE-ou before H\u0027uru Plasma (added to the latter Dec 25, 2012).\n\nThere are two approaches I can take to try to resolve.\n* Option 1 is to incorporate Jan 20-Feb 6 PhysX changes only.  This is risky because I believe some of these changes were later determined to be incorrect and revisited.\n* Option 2 is to incorporate all PhysX changes from Jan 20 2012 through when Skoader\u0027s changes were added to H\u0027uru Plasma, plus any fixes that happened soon after (if not already in CWE-ou).  Theoretically this would represents a \"known good state\" in which Skoader\u0027s changes and the frame rate lock are known to have successfully co-existed.\n\nAt the moment, I\u0027m feeling that Option 1 is riskier than Option 2, despite Option 2 touching a lot more code.","id":"b21c6145e0af960b616e405aee9c196a2234d653"}}]
+[{"date":"2021-05-31T22:03:37Z","author":"marten","fields":{"title":"Hoikas\u0027 framerate unlock https://github.com/H-uru/Plasma/pull/143","body":"","status":"New","mergeTo":"master","type":"Proposal","watchers":"+marten"},"patchset":{"number":1,"rev":1,"tip":"e455a71c2ed3eb6215c2ab5e59e712dd2a49a56b","base":"c914ba5bac1da37892ef196abe36a1177842e6ee","insertions":32,"deletions":70,"commits":1,"added":0,"type":"Proposal"}},{"date":"2021-06-05T06:13:01Z","author":"hoikas","comment":{"text":"When this is being tested, we should watch out for the fissure camera cinematic being played on link-in to Relto. This is an intermittent issue that was fairly common common in Until Uru that I remember cropping back up during the framerate unlocking.","id":"6f38f4cde0ca8941876c452270f71496728e1a40"},"fields":{"watchers":"+hoikas"}},{"date":"2021-06-14T21:05:34Z","author":"marten","comment":{"text":"Just a quick note that this commit is not ready for prime time.  It builds, but it crashes.\n\nSome notes:\n* In H\u0027uru Plasma, the unlock frame rate patch was introduced Feb 8, 2012.  \n* The unlock frame rate change is relatively straightforward, but includes a PhysX change.\n* The crash doesn\u0027t appear to be happening in any of the changed code.\n* There are prior PhysX changes in H\u0027uru Plasma from Jan 20 2012 to Feb 6 2012 not yet ported to CWE-ou.\n* Furthermore, PhysX changes from Skoader were introduced in CWE-ou before H\u0027uru Plasma (added to the latter Dec 25, 2012).\n\nThere are two approaches I can take to try to resolve.\n* Option 1 is to incorporate Jan 20-Feb 6 PhysX changes only.  This is risky because I believe some of these changes were later determined to be incorrect and revisited.\n* Option 2 is to incorporate all PhysX changes from Jan 20 2012 through when Skoader\u0027s changes were added to H\u0027uru Plasma, plus any fixes that happened soon after (if not already in CWE-ou).  Theoretically this would represents a \"known good state\" in which Skoader\u0027s changes and the frame rate lock are known to have successfully co-existed.\n\nAt the moment, I\u0027m feeling that Option 1 is riskier than Option 2, despite Option 2 touching a lot more code.","id":"b21c6145e0af960b616e405aee9c196a2234d653"}},{"date":"2021-06-25T05:04:22Z","author":"marten","comment":{"text":"@Hoikas has recommended that I take Option 3 - to drop the PhysX changes that were originally bundled with the frame rate unlock in H\u0027uru.  He and I have both confirmed that this appears to provide a working build.\n\nI will prepare the PhysX changes from Jan 2012 through February 2013 in a separate ticket for consideration, and these can be applied to a build along with the frame rate unlock if we find that there are any PhysX issues manifesting with the unlock by itself.","id":"68552bf1fbbddfe03e21c9752db1db954d48034f"},"fields":{"mentions":"+Hoikas"}}]