#54

id/54/54/journal.json

@@ -0,0 +1 @@
+[{"date":"2023-12-15T00:05:22Z","author":"dgelessus","fields":{"title":"Make Python.Cheat command more usable by not parsing its argument","body":"The argument is now always treated as a plain string and passed directly\nto the cheat. This is the behavior expected by all the functions in\nxCheat.py, which parse the string argument manually where needed.\n\nThe previous implementation evaluated the argument value as a Python\nexpression. This theoretically allowed passing non-string arguments, but\nnone of the cheats use this (and it\u0027s also a potential code execution\nissue). If no argument was passed, the function was called with no\narguments, which is also not supported by any of the cheats.\n\nIn practice, this required unintuitive syntax for calling the cheats\ncorrectly, for example:\n\n    Python.Cheat GetPlayerID None\n    Python.Cheat GetSDL \"\u0027FirstWeekClothing\u0027\"\n\nWith the new argument handling, these have been simplified to:\n\n    Python.Cheat GetPlayerID\n    Python.Cheat GetSDL FirstWeekClothing","status":"New","mergeTo":"master","type":"Proposal","watchers":"+dgelessus"},"patchset":{"number":1,"rev":1,"tip":"96facaa7bbcc477a4b75c5e5617fc10ac323a666","base":"883495c35ca8dd40bda4010c4734a3ad29e0078e","insertions":22,"deletions":35,"commits":1,"added":0,"type":"Proposal"}}]