#51

id/51/51/journal.json

@@ -0,0 +1 @@
+[{"date":"2023-06-25T15:49:44Z","author":"dgelessus","fields":{"title":"Fix possible use after free in plRegistryPageNode::UnloadKeys (\"link sound crash on exit\")","body":"Attempted fix for the well-known \"link sound crash on exit\". Works on my machine :)\n\nTo reproduce: link two avvies to the Ferry Terminal, then close the client that linked in first, wait a second or two, then close the second client. After a few seconds, the second client will crash with this stack trace:\n\n```\nUruLive.Dev.1.918 - Internal.Release\nException type: Access violation\nCall stack (12 levels, truncated):\n __alloca_probe (0x00742C20 + 0x000001C6)\n  plResManager::IShutdown (0x0070E780 + 0x0000007E)\n   plRegistryPageNode::UnloadKeys (0x007121A0 + 0x0000001E)\n    plRegistryKeyList (0x00713D10 + 0x00000061)\n     _EplKeyImp (0x00712DA0 + 0x0000000B)\n      plKeyImp (0x005AE120 + 0x00000077)\n       hsRefCnt::UnRef (0x0049BD70 + 0x00000010)\n        _GplWin32LinkSound (0x005DF0C0 + 0x00000011)\n         plWin32StaticSound (0x005DEBE0 + 0x00000050)\n          plKey::IDecRef (0x005ABA10 + 0x00000026)\n           plResManager::IKeyUnreffed (0x0070D870 + 0x0000001E)\n            plResManager::FindPage (0x0070C2D0 + 0x00000053)\n```\n\nFix ported from [H-uru/Plasma#1400](https://github.com/H-uru/Plasma/pull/1400).\n\nCo-authored-by: Adam Johnson \u003cAdamJohnso@gmail.com\u003e","type":"Bug","severity":"Unrated","priority":"Normal","mergeTo":"master","watchers":"+dgelessus","status":"New"}}]