Browse Source

#35

meta/gitblit/tickets
rarified 3 years ago
parent
commit
912dbbb162
  1. 2
      id/35/35/journal.json

2
id/35/35/journal.json

@ -1 +1 @@
[{"date":"2022-02-04T01:54:42Z","author":"doobes","fields":{"title":"Add /saveclothing and /loadclothing commands","body":"Port of Mystler\u0027s original code to add /saveclothing and /loadclothing commands","type":"Enhancement","severity":"Unrated","priority":"Normal","mergeTo":"master","watchers":"+doobes","status":"New"}},{"date":"2022-02-04T01:56:15Z","author":"doobes","patchset":{"number":1,"rev":1,"tip":"b6b1e943b763e097d809188eb87d40bf2648d651","base":"84eedce6851fa9f85fc4464bdfbab49f778fa341","insertions":84,"deletions":0,"commits":1,"added":0,"type":"Proposal"}},{"date":"2022-02-04T13:52:21Z","author":"rarified","fields":{"status":"Open","watchers":"+rarified"}},{"date":"2022-02-04T13:52:43Z","author":"rarified","fields":{"reviewers":"+rarified"},"review":{"patchset":1,"rev":1,"score":-1}},{"date":"2022-02-04T13:58:24Z","author":"rarified","comment":{"text":"I do not believe the port is complete. In CWE there are no methods WriteToFile() and ReadClothing in class plClothingOutfit.\n\nAdditionally, to follow convention, when those methods are added to plClothingOutfit I would prefer that method ReadClothing() be named ReadFromFile() to match the existing vault state method names ReadFromVault()/WriteToVault().","id":"8699796f7f227a3a27dfaae7ae08cee948bca4ba"}},{"date":"2022-02-04T14:13:10Z","author":"rarified","fields":{"milestone":"MOULa-2022q1"}},{"date":"2022-02-04T14:13:17Z","author":"rarified","fields":{"responsible":"doobes"}},{"date":"2022-02-05T13:00:14Z","author":"doobes","patchset":{"number":1,"rev":2,"tip":"01528a4a81389751b58288558a8976c8566ecafd","parent":"b6b1e943b763e097d809188eb87d40bf2648d651","base":"84eedce6851fa9f85fc4464bdfbab49f778fa341","insertions":143,"deletions":11,"commits":3,"added":2,"type":"FastForward"}},{"date":"2022-02-05T14:19:34Z","author":"doobes","patchset":{"number":1,"rev":3,"tip":"16d1752c290c47e0526ad23b47b9f0d8024ebcd9","parent":"01528a4a81389751b58288558a8976c8566ecafd","base":"84eedce6851fa9f85fc4464bdfbab49f778fa341","insertions":138,"deletions":147,"commits":4,"added":1,"type":"FastForward"}},{"date":"2022-02-13T18:44:36Z","author":"doobes","comment":{"text":"For reference, this was the commit from Mystler on which this all was based: https://github.com/GehnShard/Plasma/commit/6025621edaddd5022548b0730b39d6623a01dd87","id":"cbc1e504cfc6f767ccacb8cd6c7be78b2632ce97"}},{"date":"2022-02-13T20:07:07Z","author":"doobes","patchset":{"number":2,"rev":1,"tip":"eb40f86349e6dc7754061fce86fd1e52f20191c5","base":"84eedce6851fa9f85fc4464bdfbab49f778fa341","insertions":360,"deletions":153,"commits":4,"added":0,"type":"Amend"}},{"date":"2022-02-21T16:35:59Z","author":"rarified","fields":{"status":"On_Hold"}},{"date":"2022-02-21T16:41:09Z","author":"rarified","comment":{"text":"I\u0027ve put this on hold. There are many H\u0027uru-dependent references still in the code. Specifically, use of plFileSystem class methods instead of the existing older pnUtPath utilities, and StringTheory references instead of wide characters.\n\nIt will require more time to retrofit than I have available at the moment. I will return to it when I have time.","id":"c10cfef497c2c017b5338be87a1eb81736bd9ba0"}},{"date":"2022-02-25T20:10:17Z","author":"rarified","reference":{"hash":"1ab6781402731ae52271655b2a46200dadb77799"}}]
[{"date":"2022-02-04T01:54:42Z","author":"doobes","fields":{"title":"Add /saveclothing and /loadclothing commands","body":"Port of Mystler\u0027s original code to add /saveclothing and /loadclothing commands","type":"Enhancement","severity":"Unrated","priority":"Normal","mergeTo":"master","watchers":"+doobes","status":"New"}},{"date":"2022-02-04T01:56:15Z","author":"doobes","patchset":{"number":1,"rev":1,"tip":"b6b1e943b763e097d809188eb87d40bf2648d651","base":"84eedce6851fa9f85fc4464bdfbab49f778fa341","insertions":84,"deletions":0,"commits":1,"added":0,"type":"Proposal"}},{"date":"2022-02-04T13:52:21Z","author":"rarified","fields":{"status":"Open","watchers":"+rarified"}},{"date":"2022-02-04T13:52:43Z","author":"rarified","fields":{"reviewers":"+rarified"},"review":{"patchset":1,"rev":1,"score":-1}},{"date":"2022-02-04T13:58:24Z","author":"rarified","comment":{"text":"I do not believe the port is complete. In CWE there are no methods WriteToFile() and ReadClothing in class plClothingOutfit.\n\nAdditionally, to follow convention, when those methods are added to plClothingOutfit I would prefer that method ReadClothing() be named ReadFromFile() to match the existing vault state method names ReadFromVault()/WriteToVault().","id":"8699796f7f227a3a27dfaae7ae08cee948bca4ba"}},{"date":"2022-02-04T14:13:10Z","author":"rarified","fields":{"milestone":"MOULa-2022q1"}},{"date":"2022-02-04T14:13:17Z","author":"rarified","fields":{"responsible":"doobes"}},{"date":"2022-02-05T13:00:14Z","author":"doobes","patchset":{"number":1,"rev":2,"tip":"01528a4a81389751b58288558a8976c8566ecafd","parent":"b6b1e943b763e097d809188eb87d40bf2648d651","base":"84eedce6851fa9f85fc4464bdfbab49f778fa341","insertions":143,"deletions":11,"commits":3,"added":2,"type":"FastForward"}},{"date":"2022-02-05T14:19:34Z","author":"doobes","patchset":{"number":1,"rev":3,"tip":"16d1752c290c47e0526ad23b47b9f0d8024ebcd9","parent":"01528a4a81389751b58288558a8976c8566ecafd","base":"84eedce6851fa9f85fc4464bdfbab49f778fa341","insertions":138,"deletions":147,"commits":4,"added":1,"type":"FastForward"}},{"date":"2022-02-13T18:44:36Z","author":"doobes","comment":{"text":"For reference, this was the commit from Mystler on which this all was based: https://github.com/GehnShard/Plasma/commit/6025621edaddd5022548b0730b39d6623a01dd87","id":"cbc1e504cfc6f767ccacb8cd6c7be78b2632ce97"}},{"date":"2022-02-13T20:07:07Z","author":"doobes","patchset":{"number":2,"rev":1,"tip":"eb40f86349e6dc7754061fce86fd1e52f20191c5","base":"84eedce6851fa9f85fc4464bdfbab49f778fa341","insertions":360,"deletions":153,"commits":4,"added":0,"type":"Amend"}},{"date":"2022-02-21T16:35:59Z","author":"rarified","fields":{"status":"On_Hold"}},{"date":"2022-02-21T16:41:09Z","author":"rarified","comment":{"text":"I\u0027ve put this on hold. There are many H\u0027uru-dependent references still in the code. Specifically, use of plFileSystem class methods instead of the existing older pnUtPath utilities, and StringTheory references instead of wide characters.\n\nIt will require more time to retrofit than I have available at the moment. I will return to it when I have time.","id":"c10cfef497c2c017b5338be87a1eb81736bd9ba0"}},{"date":"2022-02-25T20:10:17Z","author":"rarified","reference":{"hash":"1ab6781402731ae52271655b2a46200dadb77799"}},{"date":"2022-02-25T22:37:40Z","author":"rarified","reference":{"hash":"1ab6781402731ae52271655b2a46200dadb77799"}}]
Loading…
Cancel
Save