#24

id/24/24/journal.json

@@ -1 +1 @@
-[{"date":"2021-10-12T19:20:07Z","author":"hoikas","fields":{"title":"Fix StrTo(Unicode|Ansi) Argument","body":"This fixes the incorrect size being passed to StrTo(Unicode|Ansi) in `VaultAgeFindOrCreateChildAgeLink`. `arrsize()` should only be used on arrays, not pointers - and those functions are expecting the size of the destination array, not the input string length.\n\nI noticed this when investigating a user report in Discord that their avatars are giving the \"Set Active Player Failed\" error. On examining the player vault, I found that the public city instance on MOULa has 133 child age instances of Descent. There are two problems with this. First, and most apparently, there should only be one child instance per Age. Second, the Descent child Age should be parented to Neighborhood, not city. What I suspect is happening is that the unsafe (and incorrect) usage of `arrsize` is evaluating to 1 and only the first character of the Age\u0027s name is being copied into the search, resulting in both the parent link search failing and the child link search failing.\n\nThis issue should not cause crashes on either the server or client side, but it may result in the proliferation of redundant child Ages in the vault and seemingly unexpected instance linking behavior.","type":"Bug","severity":"Unrated","priority":"Normal","mergeTo":"master","watchers":"+hoikas","status":"New"}},{"date":"2021-10-12T19:20:31Z","author":"hoikas","patchset":{"number":1,"rev":1,"tip":"d7c999c8f319a1b1a9d5de605a4fefb108821ba8","base":"3489b924cefee640d47591ef05b464c70142720e","insertions":2,"deletions":2,"commits":1,"added":0,"type":"Proposal"}},{"date":"2021-10-16T16:27:34Z","author":"rarified","fields":{"status":"Open","watchers":"+rarified"}},{"date":"2021-10-16T16:27:38Z","author":"rarified","fields":{"milestone":"MOULa-2021.11"}},{"date":"2021-10-16T20:55:13Z","author":"rarified","reference":{"hash":"499432b4f0905f9a8f3cab219fc3a92e5ccf551c"}},{"date":"2021-10-17T18:50:33Z","author":"hoikas","patchset":{"number":1,"rev":2,"tip":"c65b062e0f01236630befe9184b1c92f2566bddf","parent":"d7c999c8f319a1b1a9d5de605a4fefb108821ba8","base":"3489b924cefee640d47591ef05b464c70142720e","insertions":2,"deletions":1,"commits":2,"added":1,"type":"FastForward"}},{"date":"2021-10-17T18:51:40Z","author":"hoikas","comment":{"text":"Pushed a new commit that fixes dead linking books.\n\nThese two commits are identical to H\u0027uru commit e616874 from September of 2011: https://github.com/H-uru/Plasma/commit/e616874a077b12b9cd32e528d608ecf617e7c636","id":"8c45c773a1c310760fad08eb461430630d09f0be"}},{"date":"2021-11-05T21:49:34Z","author":"rarified","fields":{"status":"Merged","mergeSha":"c99503f2ca0695027642597dbd42f13ad4548c67","mergeTo":"master","responsible":"rarified"},"patchset":{"number":2,"rev":1,"tip":"c99503f2ca0695027642597dbd42f13ad4548c67","base":"f5dc22d371a4802b2c3dfd949c5b1211a32d4c87","insertions":4,"deletions":3,"commits":3,"added":1,"type":"Rebase"}},{"date":"2022-02-25T20:10:19Z","author":"rarified","reference":{"hash":"499432b4f0905f9a8f3cab219fc3a92e5ccf551c"}},{"date":"2022-02-25T22:37:43Z","author":"rarified","reference":{"hash":"499432b4f0905f9a8f3cab219fc3a92e5ccf551c"}},{"date":"2022-05-05T15:46:35Z","author":"rarified","reference":{"hash":"499432b4f0905f9a8f3cab219fc3a92e5ccf551c"}},{"date":"2022-07-19T14:55:46Z","author":"rarified","reference":{"hash":"499432b4f0905f9a8f3cab219fc3a92e5ccf551c"}}]
+[{"date":"2021-10-12T19:20:07Z","author":"hoikas","fields":{"title":"Fix StrTo(Unicode|Ansi) Argument","body":"This fixes the incorrect size being passed to StrTo(Unicode|Ansi) in `VaultAgeFindOrCreateChildAgeLink`. `arrsize()` should only be used on arrays, not pointers - and those functions are expecting the size of the destination array, not the input string length.\n\nI noticed this when investigating a user report in Discord that their avatars are giving the \"Set Active Player Failed\" error. On examining the player vault, I found that the public city instance on MOULa has 133 child age instances of Descent. There are two problems with this. First, and most apparently, there should only be one child instance per Age. Second, the Descent child Age should be parented to Neighborhood, not city. What I suspect is happening is that the unsafe (and incorrect) usage of `arrsize` is evaluating to 1 and only the first character of the Age\u0027s name is being copied into the search, resulting in both the parent link search failing and the child link search failing.\n\nThis issue should not cause crashes on either the server or client side, but it may result in the proliferation of redundant child Ages in the vault and seemingly unexpected instance linking behavior.","type":"Bug","severity":"Unrated","priority":"Normal","mergeTo":"master","watchers":"+hoikas","status":"New"}},{"date":"2021-10-12T19:20:31Z","author":"hoikas","patchset":{"number":1,"rev":1,"tip":"d7c999c8f319a1b1a9d5de605a4fefb108821ba8","base":"3489b924cefee640d47591ef05b464c70142720e","insertions":2,"deletions":2,"commits":1,"added":0,"type":"Proposal"}},{"date":"2021-10-16T16:27:34Z","author":"rarified","fields":{"status":"Open","watchers":"+rarified"}},{"date":"2021-10-16T16:27:38Z","author":"rarified","fields":{"milestone":"MOULa-2021.11"}},{"date":"2021-10-16T20:55:13Z","author":"rarified","reference":{"hash":"499432b4f0905f9a8f3cab219fc3a92e5ccf551c"}},{"date":"2021-10-17T18:50:33Z","author":"hoikas","patchset":{"number":1,"rev":2,"tip":"c65b062e0f01236630befe9184b1c92f2566bddf","parent":"d7c999c8f319a1b1a9d5de605a4fefb108821ba8","base":"3489b924cefee640d47591ef05b464c70142720e","insertions":2,"deletions":1,"commits":2,"added":1,"type":"FastForward"}},{"date":"2021-10-17T18:51:40Z","author":"hoikas","comment":{"text":"Pushed a new commit that fixes dead linking books.\n\nThese two commits are identical to H\u0027uru commit e616874 from September of 2011: https://github.com/H-uru/Plasma/commit/e616874a077b12b9cd32e528d608ecf617e7c636","id":"8c45c773a1c310760fad08eb461430630d09f0be"}},{"date":"2021-11-05T21:49:34Z","author":"rarified","fields":{"status":"Merged","mergeSha":"c99503f2ca0695027642597dbd42f13ad4548c67","mergeTo":"master","responsible":"rarified"},"patchset":{"number":2,"rev":1,"tip":"c99503f2ca0695027642597dbd42f13ad4548c67","base":"f5dc22d371a4802b2c3dfd949c5b1211a32d4c87","insertions":4,"deletions":3,"commits":3,"added":1,"type":"Rebase"}},{"date":"2022-02-25T20:10:19Z","author":"rarified","reference":{"hash":"499432b4f0905f9a8f3cab219fc3a92e5ccf551c"}},{"date":"2022-02-25T22:37:43Z","author":"rarified","reference":{"hash":"499432b4f0905f9a8f3cab219fc3a92e5ccf551c"}},{"date":"2022-05-05T15:46:35Z","author":"rarified","reference":{"hash":"499432b4f0905f9a8f3cab219fc3a92e5ccf551c"}},{"date":"2022-07-19T14:55:46Z","author":"rarified","reference":{"hash":"499432b4f0905f9a8f3cab219fc3a92e5ccf551c"}},{"date":"2023-04-02T15:50:36Z","author":"rarified","reference":{"hash":"499432b4f0905f9a8f3cab219fc3a92e5ccf551c"}}]