From 7c6cb34cd14d58b9078d572dadafe3b13a401471 Mon Sep 17 00:00:00 2001 From: Adam Johnson Date: Sun, 19 Jan 2014 14:27:41 -0500 Subject: [PATCH] Don't eat calls in hsAssert. ShellExecuteW != NOOP. Let's get it right. --- Sources/Plasma/Apps/plUruLauncher/winmain.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Sources/Plasma/Apps/plUruLauncher/winmain.cpp b/Sources/Plasma/Apps/plUruLauncher/winmain.cpp index 571c5dee..b0499756 100644 --- a/Sources/Plasma/Apps/plUruLauncher/winmain.cpp +++ b/Sources/Plasma/Apps/plUruLauncher/winmain.cpp @@ -270,7 +270,7 @@ static HANDLE ICreateProcess(const plFileName& exe, const plString& args) info.lpFile = file.GetData(); info.fMask = SEE_MASK_NOCLOSEPROCESS | SEE_MASK_NOASYNC; info.lpParameters = args.ToWchar(); - hsAssert(ShellExecuteExW(&info), "ShellExecuteExW phailed"); + ShellExecuteExW(&info); return info.hProcess; } else { @@ -312,7 +312,7 @@ static bool IInstallRedist(const plFileName& exe) // Get the exit code so we can indicate success/failure to the redist thread DWORD code = PLASMA_OK; - hsAssert(GetExitCodeProcess(process, &code), "failed to get redist exit code"); + GetExitCodeProcess(process, &code); CloseHandle(process); return code != PLASMA_PHAILURE;