#17

id/17/17/journal.json

@@ -1 +1 @@
-[{"date":"2021-08-10T23:03:50Z","author":"hoikas","fields":{"title":"Fix race condition on first time uses of Er\u0027cana/Ahnonay books.","body":"Some of the Python code expects for explicit Age initialization to complete immediately. Rewriting that would be something of a chore, so this will prevent first time clicks on the Er\u0027cana and Ahnoying Cathedral books from causing a perma-stick.\n\nHomologue of H\u0027uru commit ec0aecd2024d964be6b1a25205c17dc70d62b3e3","type":"Bug","severity":"Unrated","priority":"Normal","mergeTo":"master","watchers":"+hoikas","status":"New"}},{"date":"2021-08-10T23:04:22Z","author":"hoikas","patchset":{"number":1,"rev":1,"tip":"b1eda42289cc8a7f68512b4c5568994fe2d39ab0","base":"2b8c81ee2a797a03197dbee85d7dda96e1bb0f2e","insertions":1,"deletions":1,"commits":1,"added":0,"type":"Proposal"}},{"date":"2021-08-11T16:03:31Z","author":"rarified","fields":{"status":"Open","watchers":"+rarified"}},{"date":"2021-08-11T16:05:22Z","author":"rarified","comment":{"text":"Is the \"right\" solution actually the Python changes?  Should this change be marked with a \"TODO\" indicating it should be resolved (in the future) in the scripting?","id":"75cf77e815ac365f748e06af3fe70ec09ad21f06"}},{"date":"2021-08-11T16:40:46Z","author":"rarified","comment":{"text":"Also, was this encountered and fixed in the H\u0027uru addition of the asynchronous vault operations?  Are there missing pieces that didn\u0027t get incorporated from the H\u0027uru scripts that does the Age initialization without races?","id":"e1deb0cc132ad91e92061e7333d820bd380239ab"}},{"date":"2021-08-11T16:42:40Z","author":"rarified","fields":{"milestone":"MOULa-2021.08"}},{"date":"2021-08-11T17:33:11Z","author":"hoikas","comment":{"text":"I suspect that a better fix would involve fixing the Python; ideally this would include design work to move the PelletCave GUID logic out of xLinkingBookGUIPopup.py into a place where it cannot be bypassed. Currently, there are many ways where the original solution as found on MOULa can leave players dead in the water without their pellet cave set up correctly. This is quite a bit of design and coding (especially considering the complexity of xLinkingBookGUIPopup.py), so I think I elected to defer since only two books were affected.\n\nWhen I saw that this was a race condition coming from Python, I went and looked back over all the H-uru/Plasma Python commits from 2011-2012 and saw nothing else. A quick history review of the offender, however, revealed commit ec0aecd2024d964be6b1a25205c17dc70d62b3e3 whose parent, f45679a54f0400203d25f6e6579c119ed9a1f205 was brought over in ticket #10. I suspect we found these regressions when doing the initial testing for the Gehn Shard, but I can\u0027t locate any corresponding pull request atm.","id":"dca3d28dc0253a45a9cb8552d75fd42acc81324c"}},{"date":"2021-08-11T17:33:12Z","author":"hoikas","comment":{"text":"I suspect that a better fix would involve fixing the Python; ideally this would include design work to move the PelletCave GUID logic out of xLinkingBookGUIPopup.py into a place where it cannot be bypassed. Currently, there are many ways where the original solution as found on MOULa can leave players dead in the water without their pellet cave set up correctly. This is quite a bit of design and coding (especially considering the complexity of xLinkingBookGUIPopup.py), so I think I elected to defer since only two books were affected.\n\nWhen I saw that this was a race condition coming from Python, I went and looked back over all the H-uru/Plasma Python commits from 2011-2012 and saw nothing else. A quick history review of the offender, however, revealed commit ec0aecd2024d964be6b1a25205c17dc70d62b3e3 whose parent, f45679a54f0400203d25f6e6579c119ed9a1f205 was brought over in ticket #10. I suspect we found these regressions when doing the initial testing for the Gehn Shard, but I can\u0027t locate any corresponding pull request atm.","id":"5fe3db335ca42f366790d296219b687165a52909"}},{"date":"2021-08-11T20:17:39Z","author":"rarified","reference":{"hash":"1d309e3ce543ec60421644459731992ae1aa07a5"}}]
+[{"date":"2021-08-10T23:03:50Z","author":"hoikas","fields":{"title":"Fix race condition on first time uses of Er\u0027cana/Ahnonay books.","body":"Some of the Python code expects for explicit Age initialization to complete immediately. Rewriting that would be something of a chore, so this will prevent first time clicks on the Er\u0027cana and Ahnoying Cathedral books from causing a perma-stick.\n\nHomologue of H\u0027uru commit ec0aecd2024d964be6b1a25205c17dc70d62b3e3","type":"Bug","severity":"Unrated","priority":"Normal","mergeTo":"master","watchers":"+hoikas","status":"New"}},{"date":"2021-08-10T23:04:22Z","author":"hoikas","patchset":{"number":1,"rev":1,"tip":"b1eda42289cc8a7f68512b4c5568994fe2d39ab0","base":"2b8c81ee2a797a03197dbee85d7dda96e1bb0f2e","insertions":1,"deletions":1,"commits":1,"added":0,"type":"Proposal"}},{"date":"2021-08-11T16:03:31Z","author":"rarified","fields":{"status":"Open","watchers":"+rarified"}},{"date":"2021-08-11T16:05:22Z","author":"rarified","comment":{"text":"Is the \"right\" solution actually the Python changes?  Should this change be marked with a \"TODO\" indicating it should be resolved (in the future) in the scripting?","id":"75cf77e815ac365f748e06af3fe70ec09ad21f06"}},{"date":"2021-08-11T16:40:46Z","author":"rarified","comment":{"text":"Also, was this encountered and fixed in the H\u0027uru addition of the asynchronous vault operations?  Are there missing pieces that didn\u0027t get incorporated from the H\u0027uru scripts that does the Age initialization without races?","id":"e1deb0cc132ad91e92061e7333d820bd380239ab"}},{"date":"2021-08-11T16:42:40Z","author":"rarified","fields":{"milestone":"MOULa-2021.08"}},{"date":"2021-08-11T17:33:11Z","author":"hoikas","comment":{"text":"I suspect that a better fix would involve fixing the Python; ideally this would include design work to move the PelletCave GUID logic out of xLinkingBookGUIPopup.py into a place where it cannot be bypassed. Currently, there are many ways where the original solution as found on MOULa can leave players dead in the water without their pellet cave set up correctly. This is quite a bit of design and coding (especially considering the complexity of xLinkingBookGUIPopup.py), so I think I elected to defer since only two books were affected.\n\nWhen I saw that this was a race condition coming from Python, I went and looked back over all the H-uru/Plasma Python commits from 2011-2012 and saw nothing else. A quick history review of the offender, however, revealed commit ec0aecd2024d964be6b1a25205c17dc70d62b3e3 whose parent, f45679a54f0400203d25f6e6579c119ed9a1f205 was brought over in ticket #10. I suspect we found these regressions when doing the initial testing for the Gehn Shard, but I can\u0027t locate any corresponding pull request atm.","id":"dca3d28dc0253a45a9cb8552d75fd42acc81324c"}},{"date":"2021-08-11T17:33:12Z","author":"hoikas","comment":{"text":"I suspect that a better fix would involve fixing the Python; ideally this would include design work to move the PelletCave GUID logic out of xLinkingBookGUIPopup.py into a place where it cannot be bypassed. Currently, there are many ways where the original solution as found on MOULa can leave players dead in the water without their pellet cave set up correctly. This is quite a bit of design and coding (especially considering the complexity of xLinkingBookGUIPopup.py), so I think I elected to defer since only two books were affected.\n\nWhen I saw that this was a race condition coming from Python, I went and looked back over all the H-uru/Plasma Python commits from 2011-2012 and saw nothing else. A quick history review of the offender, however, revealed commit ec0aecd2024d964be6b1a25205c17dc70d62b3e3 whose parent, f45679a54f0400203d25f6e6579c119ed9a1f205 was brought over in ticket #10. I suspect we found these regressions when doing the initial testing for the Gehn Shard, but I can\u0027t locate any corresponding pull request atm.","id":"5fe3db335ca42f366790d296219b687165a52909"}},{"date":"2021-08-11T20:17:39Z","author":"rarified","reference":{"hash":"1d309e3ce543ec60421644459731992ae1aa07a5"}},{"date":"2021-08-12T20:44:02Z","author":"rarified","fields":{"status":"Merged","mergeSha":"7b4d9e8e3fe941e7bf67e86f8865cd989ff78665","mergeTo":"master","responsible":"rarified"},"patchset":{"number":2,"rev":1,"tip":"7b4d9e8e3fe941e7bf67e86f8865cd989ff78665","base":"67a9e4a8929d39cbbedcd83ea66223ac9331eee1","insertions":1,"deletions":1,"commits":2,"added":1,"type":"Rebase"}}]