#4

id/04/4/journal.json

@@ -1 +1 @@
-[{"date":"2021-03-26T21:51:01Z","author":"rarified","fields":{"title":"Hoikas support for widescreen field of view (Hor+) https://github.com/H-uru/Plasma/commit/1e7cbc3daf59ff96f2ee171352d3fd4b2a8952e3 https://github.com/H-uru/Plasma/commit/2a7d97d52074ea2dbfac2e50b0bfa4f55d5ae6df https://github.com/H-uru/Plasma/commit/a8b667ca1e42620428683e6f2495f047eb682c6c Includes selected changes from \"Obliterate hsBool\": https://github.com/H-uru/Plasma/commit/a709e17069dcf299e1cf9470b01b646b6f35b33f","body":"","status":"New","mergeTo":"master","type":"Proposal","watchers":"+rarified"},"patchset":{"number":1,"rev":1,"tip":"9a3f202d665e3e646a45cb49b59ee2e9c3628900","base":"f5c2078649eddd3621924c77b8f35973359f92b5","insertions":136,"deletions":106,"commits":1,"added":0,"type":"Proposal"}},{"date":"2021-03-26T21:52:17Z","author":"rarified","fields":{"title":"Hoikas support for widescreen field of view (Hor+)","body":"https://github.com/H-uru/Plasma/commit/1e7cbc3daf59ff96f2ee171352d3fd4b2a8952e3\nhttps://github.com/H-uru/Plasma/commit/2a7d97d52074ea2dbfac2e50b0bfa4f55d5ae6df\nhttps://github.com/H-uru/Plasma/commit/a8b667ca1e42620428683e6f2495f047eb682c6c\n\nIncludes selected changes from \"Obliterate hsBool\": \nhttps://github.com/H-uru/Plasma/commit/a709e17069dcf299e1cf9470b01b646b6f35b33f","status":"Open","responsible":"rarified","severity":"Minor"}},{"date":"2021-03-26T22:06:11Z","author":"marten","fields":{"watchers":"+marten"}},{"date":"2021-03-26T22:57:02Z","author":"marten","comment":{"text":"One theme you\u0027ll see in these changes is that calls to functions of the plVirtualCam1 object have been simplified.\n\nIn the original code you\u0027d never see plVC1::SetAspectRatio() called without immediately calling plVC1::SetFOV().\n\nNow there\u0027s a plVC1::Refresh() command which calls an updated plVC1::SetAspectRatio(), which in turn calls plVC1::SetFOV().\n\nIt\u0027s cleaner and ensures the SetFOV step is never missed.","id":"fe3e2bf959673cdf62aa2e1005808c6cfcb0b803"}},{"date":"2021-03-27T19:29:53Z","author":"rarified","comment":{"text":"Approved for testing.\n\nI am not familiar enough with the details of the Camera operation, but the outline of what I saw looked good.","id":"90067f1c19fbb13819abf2d05405f7142ec5cba4"}},{"date":"2021-03-27T19:30:00Z","author":"rarified","fields":{"reviewers":"+rarified"},"review":{"patchset":1,"rev":1,"score":2}},{"date":"2021-03-27T19:33:36Z","author":"rarified","fields":{"status":"Merged","mergeSha":"d286bc503ddb695aec40cb20e533a8d2e273c9f8","mergeTo":"master"},"patchset":{"number":2,"rev":1,"tip":"d286bc503ddb695aec40cb20e533a8d2e273c9f8","base":"5cf75b45524d13c1bb585f11d917ca0568e6f7f7","insertions":136,"deletions":106,"commits":2,"added":1,"type":"Rebase"}},{"date":"2021-05-09T20:38:21Z","author":"rarified","reference":{"hash":"348858aef176ae27b4001f556190c687363fa5d4"}},{"date":"2021-05-18T19:08:50Z","author":"rarified","reference":{"hash":"348858aef176ae27b4001f556190c687363fa5d4"}},{"date":"2021-06-27T16:33:11Z","author":"rarified","reference":{"hash":"348858aef176ae27b4001f556190c687363fa5d4"}},{"date":"2021-07-22T19:51:50Z","author":"rarified","reference":{"hash":"348858aef176ae27b4001f556190c687363fa5d4"}}]
+[{"date":"2021-03-26T21:51:01Z","author":"rarified","fields":{"title":"Hoikas support for widescreen field of view (Hor+) https://github.com/H-uru/Plasma/commit/1e7cbc3daf59ff96f2ee171352d3fd4b2a8952e3 https://github.com/H-uru/Plasma/commit/2a7d97d52074ea2dbfac2e50b0bfa4f55d5ae6df https://github.com/H-uru/Plasma/commit/a8b667ca1e42620428683e6f2495f047eb682c6c Includes selected changes from \"Obliterate hsBool\": https://github.com/H-uru/Plasma/commit/a709e17069dcf299e1cf9470b01b646b6f35b33f","body":"","status":"New","mergeTo":"master","type":"Proposal","watchers":"+rarified"},"patchset":{"number":1,"rev":1,"tip":"9a3f202d665e3e646a45cb49b59ee2e9c3628900","base":"f5c2078649eddd3621924c77b8f35973359f92b5","insertions":136,"deletions":106,"commits":1,"added":0,"type":"Proposal"}},{"date":"2021-03-26T21:52:17Z","author":"rarified","fields":{"title":"Hoikas support for widescreen field of view (Hor+)","body":"https://github.com/H-uru/Plasma/commit/1e7cbc3daf59ff96f2ee171352d3fd4b2a8952e3\nhttps://github.com/H-uru/Plasma/commit/2a7d97d52074ea2dbfac2e50b0bfa4f55d5ae6df\nhttps://github.com/H-uru/Plasma/commit/a8b667ca1e42620428683e6f2495f047eb682c6c\n\nIncludes selected changes from \"Obliterate hsBool\": \nhttps://github.com/H-uru/Plasma/commit/a709e17069dcf299e1cf9470b01b646b6f35b33f","status":"Open","responsible":"rarified","severity":"Minor"}},{"date":"2021-03-26T22:06:11Z","author":"marten","fields":{"watchers":"+marten"}},{"date":"2021-03-26T22:57:02Z","author":"marten","comment":{"text":"One theme you\u0027ll see in these changes is that calls to functions of the plVirtualCam1 object have been simplified.\n\nIn the original code you\u0027d never see plVC1::SetAspectRatio() called without immediately calling plVC1::SetFOV().\n\nNow there\u0027s a plVC1::Refresh() command which calls an updated plVC1::SetAspectRatio(), which in turn calls plVC1::SetFOV().\n\nIt\u0027s cleaner and ensures the SetFOV step is never missed.","id":"fe3e2bf959673cdf62aa2e1005808c6cfcb0b803"}},{"date":"2021-03-27T19:29:53Z","author":"rarified","comment":{"text":"Approved for testing.\n\nI am not familiar enough with the details of the Camera operation, but the outline of what I saw looked good.","id":"90067f1c19fbb13819abf2d05405f7142ec5cba4"}},{"date":"2021-03-27T19:30:00Z","author":"rarified","fields":{"reviewers":"+rarified"},"review":{"patchset":1,"rev":1,"score":2}},{"date":"2021-03-27T19:33:36Z","author":"rarified","fields":{"status":"Merged","mergeSha":"d286bc503ddb695aec40cb20e533a8d2e273c9f8","mergeTo":"master"},"patchset":{"number":2,"rev":1,"tip":"d286bc503ddb695aec40cb20e533a8d2e273c9f8","base":"5cf75b45524d13c1bb585f11d917ca0568e6f7f7","insertions":136,"deletions":106,"commits":2,"added":1,"type":"Rebase"}},{"date":"2021-05-09T20:38:21Z","author":"rarified","reference":{"hash":"348858aef176ae27b4001f556190c687363fa5d4"}},{"date":"2021-05-18T19:08:50Z","author":"rarified","reference":{"hash":"348858aef176ae27b4001f556190c687363fa5d4"}},{"date":"2021-06-27T16:33:11Z","author":"rarified","reference":{"hash":"348858aef176ae27b4001f556190c687363fa5d4"}},{"date":"2021-07-22T19:51:50Z","author":"rarified","reference":{"hash":"348858aef176ae27b4001f556190c687363fa5d4"}},{"date":"2021-08-11T20:17:47Z","author":"rarified","reference":{"hash":"348858aef176ae27b4001f556190c687363fa5d4"}}]