From 571bdbab01673589e14689ec893f302c3f9433ef Mon Sep 17 00:00:00 2001 From: Adam Johnson Date: Wed, 22 Jan 2014 19:02:23 -0500 Subject: [PATCH] Fix leak in GetLinkToMyNeighborhood pyAgeLinkStruct copies the plAgeLinkStruct, so we can create our initial ALS on the stack and avoid crazy memory logic. --- Sources/Plasma/FeatureLib/pfPython/pyVaultPlayerNode.cpp | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/Sources/Plasma/FeatureLib/pfPython/pyVaultPlayerNode.cpp b/Sources/Plasma/FeatureLib/pfPython/pyVaultPlayerNode.cpp index 57189f3a..14416120 100644 --- a/Sources/Plasma/FeatureLib/pfPython/pyVaultPlayerNode.cpp +++ b/Sources/Plasma/FeatureLib/pfPython/pyVaultPlayerNode.cpp @@ -183,14 +183,12 @@ PyObject *pyVaultPlayerNode::GetPlayerInfo() PyObject *pyVaultPlayerNode::GetLinkToMyNeighborhood() { - plAgeLinkStruct * link = new plAgeLinkStruct(); - - if (VaultGetLinkToMyNeighborhood(link)) { - PyObject * result = pyAgeLinkStruct::New(link); + plAgeLinkStruct link; + if (VaultGetLinkToMyNeighborhood(&link)) { + PyObject * result = pyAgeLinkStruct::New(&link); return result; } - delete link; PYTHON_RETURN_NONE; }