From 47c8e61c5e8233f273738052b57feea391e665cf Mon Sep 17 00:00:00 2001 From: rarified Date: Fri, 4 Feb 2022 07:13:10 -0700 Subject: [PATCH] #35 --- id/35/35/journal.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/id/35/35/journal.json b/id/35/35/journal.json index 12ba2277..fdeb7d0f 100644 --- a/id/35/35/journal.json +++ b/id/35/35/journal.json @@ -1 +1 @@ -[{"date":"2022-02-04T01:54:42Z","author":"doobes","fields":{"title":"Add /saveclothing and /loadclothing commands","body":"Port of Mystler\u0027s original code to add /saveclothing and /loadclothing commands","type":"Enhancement","severity":"Unrated","priority":"Normal","mergeTo":"master","watchers":"+doobes","status":"New"}},{"date":"2022-02-04T01:56:15Z","author":"doobes","patchset":{"number":1,"rev":1,"tip":"b6b1e943b763e097d809188eb87d40bf2648d651","base":"84eedce6851fa9f85fc4464bdfbab49f778fa341","insertions":84,"deletions":0,"commits":1,"added":0,"type":"Proposal"}},{"date":"2022-02-04T13:52:21Z","author":"rarified","fields":{"status":"Open","watchers":"+rarified"}},{"date":"2022-02-04T13:52:43Z","author":"rarified","fields":{"reviewers":"+rarified"},"review":{"patchset":1,"rev":1,"score":-1}},{"date":"2022-02-04T13:58:24Z","author":"rarified","comment":{"text":"I do not believe the port is complete. In CWE there are no methods WriteToFile() and ReadClothing in class plClothingOutfit.\n\nAdditionally, to follow convention, when those methods are added to plClothingOutfit I would prefer that method ReadClothing() be named ReadFromFile() to match the existing vault state method names ReadFromVault()/WriteToVault().","id":"8699796f7f227a3a27dfaae7ae08cee948bca4ba"}}] \ No newline at end of file +[{"date":"2022-02-04T01:54:42Z","author":"doobes","fields":{"title":"Add /saveclothing and /loadclothing commands","body":"Port of Mystler\u0027s original code to add /saveclothing and /loadclothing commands","type":"Enhancement","severity":"Unrated","priority":"Normal","mergeTo":"master","watchers":"+doobes","status":"New"}},{"date":"2022-02-04T01:56:15Z","author":"doobes","patchset":{"number":1,"rev":1,"tip":"b6b1e943b763e097d809188eb87d40bf2648d651","base":"84eedce6851fa9f85fc4464bdfbab49f778fa341","insertions":84,"deletions":0,"commits":1,"added":0,"type":"Proposal"}},{"date":"2022-02-04T13:52:21Z","author":"rarified","fields":{"status":"Open","watchers":"+rarified"}},{"date":"2022-02-04T13:52:43Z","author":"rarified","fields":{"reviewers":"+rarified"},"review":{"patchset":1,"rev":1,"score":-1}},{"date":"2022-02-04T13:58:24Z","author":"rarified","comment":{"text":"I do not believe the port is complete. In CWE there are no methods WriteToFile() and ReadClothing in class plClothingOutfit.\n\nAdditionally, to follow convention, when those methods are added to plClothingOutfit I would prefer that method ReadClothing() be named ReadFromFile() to match the existing vault state method names ReadFromVault()/WriteToVault().","id":"8699796f7f227a3a27dfaae7ae08cee948bca4ba"}},{"date":"2022-02-04T14:13:10Z","author":"rarified","fields":{"milestone":"MOULa-2022q1"}}] \ No newline at end of file