Fix some noteworthy warnings (mostly hsBool->bool incompatibility) and missing headers

Sources/Plasma/CoreLib/hsFastMath.cpp

@@ -604,7 +604,7 @@ float hsFastMath::IATan2OverTwoPi(float y, float x)
     if( (x == 0)&&(y == 0) )
         return 0;
 
-    bool xNeg, yNeg;
+    int xNeg, yNeg;
     if((yNeg = (y < 0)))y = -y;
     if((xNeg = (x < 0)))x = -x;
     bool yBigger = y >= x;

Sources/Plasma/FeatureLib/pfConsoleCore/pfConsoleCmd.cpp

@@ -565,7 +565,7 @@ uint8_t   pfConsoleCmd::GetSigEntry( uint8_t i )
 
 const char  *pfConsoleCmd::GetSignature( void )
 {
-    char string[256];
+    static char string[256];
     
     int     i;
     char    pStr[ 128 ];

Sources/Plasma/FeatureLib/pfPython/cyMisc.cpp

@@ -85,6 +85,7 @@ You can contact Cyan Worlds, Inc. by email legal@cyan.com
 #include "pyAgeInfoStruct.h"
 #include "pyAgeLinkStruct.h"
 #include "pyAlarm.h"
+#include "pyGeometry3.h"
 #include "pfMessage/pfKIMsg.h"
 #include "plNetMessage/plNetMessage.h"
 #include "pfCamera/plVirtualCamNeu.h"

Sources/Plasma/FeatureLib/pfPython/pyGUIControl.cpp

@@ -51,6 +51,7 @@ You can contact Cyan Worlds, Inc. by email legal@cyan.com
 
 #include "pyGUIDialog.h"
 #include "pyColor.h"
+#include "pyGeometry3.h"
 
 #include "pyGUIControlCheckBox.h"
 

Sources/Plasma/FeatureLib/pfPython/pyGUIControl.h

@@ -54,6 +54,7 @@ You can contact Cyan Worlds, Inc. by email legal@cyan.com
 
 class pyGUIDialog;
 class pyColor;
+class pyPoint3;
 
 class pyGUIControl
 {

Sources/Plasma/FeatureLib/pfPython/pyGUIControlClickMap.cpp

@@ -49,6 +49,7 @@ You can contact Cyan Worlds, Inc. by email legal@cyan.com
 
 #include "pyGUIControlClickMap.h"
 #include "pyGUIDialog.h"
+#include "pyGeometry3.h"
 
 pyGUIControlClickMap::pyGUIControlClickMap(pyKey& gckey) : pyGUIControl(gckey)
 {

Sources/Plasma/FeatureLib/pfPython/pyGUIControlDraggable.cpp

@@ -48,6 +48,7 @@ You can contact Cyan Worlds, Inc. by email legal@cyan.com
 
 #include "pyGUIControlDraggable.h"
 #include "pyGUIDialog.h"
+#include "pyGeometry3.h"
 
 pyGUIControlDraggable::pyGUIControlDraggable(pyKey& gckey) : pyGUIControl(gckey)
 {

Sources/Plasma/FeatureLib/pfPython/pyGUIControlGlue.cpp

@@ -45,6 +45,7 @@ You can contact Cyan Worlds, Inc. by email legal@cyan.com
 #pragma hdrstop
 
 #include "pyGUIControl.h"
+#include "pyGeometry3.h"
 
 // glue functions
 PYTHON_CLASS_DEFINITION(ptGUIControl, pyGUIControl);

Sources/Plasma/FeatureLib/pfPython/pyImage.cpp

@@ -46,6 +46,7 @@ You can contact Cyan Worlds, Inc. by email legal@cyan.com
 #pragma hdrstop
 
 #include "pyImage.h"
+#include "pyGeometry3.h"
 #include "plJPEG/plJPEG.h"
 #include "plGImage/plPNG.h"
 #include "pnKeyedObject/plUoid.h"

Sources/Plasma/NucleusLib/pnMessage/plMessage.cpp

@@ -369,7 +369,7 @@ int plMsgCStringHelper::Poke(const char * str, hsStream* stream, const uint32_t
 {
     plMessage::plStrLen len = (str) ? strlen(str) : 0;
     stream->WriteLE(len);
-    if (strlen)
+    if (len)
         stream->Write(len,str);
     return stream->GetPosition();
 }

Sources/Plasma/PubUtilLib/plDrawable/plDynaDecal.h

@@ -85,8 +85,8 @@ protected:
     uint16_t      fNumIdx;
 
     double      fBirth;
-    float    fInitAtten;
-    bool        fFlags;
+    float       fInitAtten;
+    uint32_t    fFlags;
 
     plDecalVtxFormat*   fVtxBase; // Safe pointer, the buffer data will outlive this decal
     

Sources/Plasma/PubUtilLib/plGImage/plWinFontCache.cpp

@@ -155,7 +155,7 @@ HFONT   plWinFontCache::IMakeFont( const char *face, int height, int weight, boo
                 err = "Height of created font does not match";
             if( fontInfo.lfWeight != weight )
                 err = "Weight of created font does not match";
-            if( fontInfo.lfItalic != italic )
+            if( static_cast<bool>(fontInfo.lfItalic) != italic )
                 err = "Italic-ness of created font does not match";
             if( stricmp( fontInfo.lfFaceName, face ) != 0 )
                 err = "Face of created font does not match";

Sources/Tools/MaxComponent/plAudioComponents.cpp

@@ -2813,7 +2813,6 @@ public:
 
     BOOL DlgProc( TimeValue t, IParamMap2 *map, HWND hWnd, UINT msg, WPARAM wParam, LPARAM lParam )
     {
-        int             i;
         IParamBlock2    *pb = map->GetParamBlock();
 
 
@@ -2827,7 +2826,7 @@ public:
                     ComboBox_ResetContent( comboBox );
 
 #ifdef EAX_SDK_AVAILABLE
-                    for( i = 0; i < /*sizeof( EAX30_ORIGINAL_PRESETS ) 
+                    for( int i = 0; i < /*sizeof( EAX30_ORIGINAL_PRESETS ) 
                         / sizeof( EAXLISTENERPROPERTIES )*/26 ; i++ )
                         ComboBox_AddString( comboBox, EAX30_ORIGINAL_PRESET_NAMES[ i ] );
 #endif

Sources/Tools/MaxMain/plMaxNodeBase.cpp

@@ -1026,7 +1026,7 @@ Matrix3 plMaxNodeBase::GetWorldToParent(TimeValue t)
     GetTMController()->GetLocalTMComponents(t, cmpts, parentMatrix);
 
     Quat q;
-    if( cmpts.rotRep == TMComponentsArg::RotationRep::kQuat )
+    if( cmpts.rotRep == TMComponentsArg::kQuat )
         q = Quat(rot);
     else
         EulerToQuat(rot, q, cmpts.rotRep);

Sources/Tools/MaxPlasmaLights/plRTProjDirLight.cpp

@@ -463,7 +463,7 @@ void    plRTProjDirLight::SetFallsize( TimeValue time, float f )
 RefResult plRTProjDirLight::EvalLightState( TimeValue t, Interval& valid, LightState *ls )
 {
     ls->type = DIRECT_LGT;
-    if( fLightPB->GetInt( kLightOn, t ) == true )
+    if( fLightPB->GetInt( kLightOn, t ) )
         ls->color = GetRGBColor( t, valid );
     else
         ls->color = Color( 0, 0, 0 );

Sources/Tools/MaxPlasmaLights/plRealTimeLightBase.cpp

@@ -1430,7 +1430,7 @@ RefResult plRTLightBase::EvalLightState(TimeValue t, Interval& valid, LightState
 {
         //t uselight;
 //#if 0 //fLightPB->GetInt(kLightOn, t);
-    if(fLightPB->GetInt(kLightOn, t) == true)
+    if(fLightPB->GetInt(kLightOn, t) )
         ls->color = GetRGBColor(t,valid);
     else
         ls->color = Color(0,0,0);