From 31156794ad4a46084c864376d27c3f8940f34369 Mon Sep 17 00:00:00 2001 From: Adam Johnson Date: Sun, 17 Oct 2021 15:13:12 -0400 Subject: [PATCH] Fix reference counting problem in pyVaultNode::AddNode(). This is fixed in H'uru via extensive use of RAII around vault nodes. --- Sources/Plasma/FeatureLib/pfPython/pyVaultNode.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Sources/Plasma/FeatureLib/pfPython/pyVaultNode.cpp b/Sources/Plasma/FeatureLib/pfPython/pyVaultNode.cpp index 07d92d9e..534bc3fc 100644 --- a/Sources/Plasma/FeatureLib/pfPython/pyVaultNode.cpp +++ b/Sources/Plasma/FeatureLib/pfPython/pyVaultNode.cpp @@ -441,7 +441,8 @@ PyObject* pyVaultNode::AddNode(pyVaultNode* pynode, PyObject* cbObject, UInt32 c ); if (newNode) { - newNode->IncRef(); + // No need to increment the newNode's reference count; the pynode + // will steal the current reference. pynode->fNode->DecRef(); pynode->fNode = newNode; }